server/mangos
5
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Player::UpdateCombatSkills -> compare 5 x PlayerLevel with GetBaseWeaponSkillValue / GetBaseDefenseSkillValue (#160)

Browse Source 
GetBaseWeaponSkillValue and GetBaseDefenseSkillValue -> return GetBaseSkillValue, but this return with added SKILL_PERM_BONUS
Due to this the skilldif formula in Player::UpdateCombatSkills is miscalculating maximum value
I have changed GetBaseWeaponSkillValue and GetBaseDefenseSkillValue to utilize GetPureSkillValue correcting the calculation
This commit is contained in:
Zilvereyes 2016-08-29 09:28:29 +02:00 committed by Antz
parent 0888756ab7
commit 04ca95d54c
2 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/game/Object/Player.cpp
View File

@ -18793,7 +18793,7 @@ uint32 Player::GetBaseWeaponSkillValue(WeaponAttackType attType) const
// weapon skill or (unarmed for base attack) // weapon skill or (unarmed for base attack)
uint32 skill = item ? item->GetSkill() : uint32(SKILL_UNARMED); uint32 skill = item ? item->GetSkill() : uint32(SKILL_UNARMED);
return GetBaseSkillValue(skill); return GetPureSkillValue(skill);
} }
void Player::ResurectUsingRequestData() void Player::ResurectUsingRequestData()

2
src/game/Object/Player.h
View File

@ -1750,7 +1750,7 @@ class Player : public Unit
uint32 GetBaseDefenseSkillValue() const uint32 GetBaseDefenseSkillValue() const
{ {
return GetBaseSkillValue(SKILL_DEFENSE); return GetPureSkillValue(SKILL_DEFENSE);
} }
uint32 GetBaseWeaponSkillValue(WeaponAttackType attType) const; uint32 GetBaseWeaponSkillValue(WeaponAttackType attType) const;