server/mangos
5
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

FIX : HandleAdditemCommand (#167)

Browse Source 
- Fix a behaviour that lead to remove enchant_id applied if item was given to a non-GM character
- Enchance Algorithm description

Whitespace
This commit is contained in:
Elmsroth 2021-12-28 15:28:34 +01:00 committed by GitHub
parent cdb0945e33
commit 43d5069dfe
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 15 additions and 18 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

33
src/game/ChatCommands/PlayerCommands.cpp
View File

@ -1125,26 +1125,23 @@ bool ChatHandler::HandleAddItemCommand(char* args)
Item* item = plTarget->StoreNewItem(dest, itemId, true, Item::GenerateItemRandomPropertyId(itemId)); Item* item = plTarget->StoreNewItem(dest, itemId, true, Item::GenerateItemRandomPropertyId(itemId));
for (ItemPosCountVec::const_iterator itr = dest.begin(); itr != dest.end(); ++itr)
{
if (pl == plTarget)
{
// Remove binding (let GM give it to another player later)
if (Item* item1 = pl->GetItemByPos(itr->pos))
{
item1->SetBinding(false);
// Perhaps we can enchant the item
if (enchant_id)
{
item1->SetEnchantment(PERM_ENCHANTMENT_SLOT, enchant_id, 0, 0);
}
}
}
}
if (count > 0 && item) if (count > 0 && item)
{ {
// Perhaps we can enchant the item
if (enchant_id)
{
item->SetEnchantment(PERM_ENCHANTMENT_SLOT, enchant_id, 0, 0);
}
// If player is GM, then remove item binding to allow to give it later toplayer
// WARNING : If enchant is applied, the item can stay souldbound if it is a soulbound enchant id.
// e.g : enchant id is 1900 (Crusader) => Item stays "LINKED WHEN PICKED UP"
// if enchant id is 2606 (+30AP) => Item becomes is Soulbound even if added on a GM character
if (pl == plTarget)
{
item->SetBinding(false);
}
pl->SendNewItem(item, count, false, true); pl->SendNewItem(item, count, false, true);
if (pl != plTarget) if (pl != plTarget)
{ {