server/mangos
5
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Incomplete text should not be shown for completed quests (#35)

Browse Source 
* Incomplete text should not be shown for completed quests

* Use GetReqItemsCount instead
This commit is contained in:
brotalnia 2017-07-17 11:42:05 +03:00 committed by Antz
parent 74147b553d
commit 7c8a4fc7d3
1 changed files with 5 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
src/game/WorldHandlers/GossipDef.cpp
View File

@ -727,8 +727,11 @@ void PlayerMenu::SendQuestGiverRequestItems(Quest const* pQuest, ObjectGuid npcG
}
}
// We may wish a better check, perhaps checking the real quest requirements
if (RequestItemsText.empty())
// Quests that don't require items use the RequestItemsText field to store the text
// that is shown when you talk to the quest giver while the quest is incomplete.
// Therefore the text should not be shown for them when the quest is complete.
// For quests that do require items, it is self explanatory.
if (RequestItemsText.empty() || ((pQuest->GetReqItemsCount() == 0) && Completable))
{
SendQuestGiverOfferReward(pQuest, npcGUID, true);
return;