The code is checking the database value against 1 << spellInfo->School so it should match the spell schools defined in the code (SharedDefines.h). Or translated into bits and mask values you can use in the database:
SPELL_SCHOOL_NORMAL = bit 0 (0x00000001)
SPELL_SCHOOL_HOLY = bit 1 (0x00000002)
SPELL_SCHOOL_FIRE = bit 2 (0x00000004)
SPELL_SCHOOL_NATURE = bit 3 (0x00000008)
SPELL_SCHOOL_FROST = bit 4 (0x00000010)
SPELL_SCHOOL_SHADOW = bit 5 (0x00000020)
SPELL_SCHOOL_ARCANE = bit 6 (0x00000040)
* fix hunter spell Mend pet out Range
fix hunter spell Mend pet out Range deduction MP problem
* fix hunter spell Mend pet out Range
fix hunter spell Mend pet out Range deduction MP problem
* Update SharedDefines.h
* Hunter fixes
-RevivePet will now properly revive the pet
-CallPet will detect if the pet is dead; TODO: what if the pet is dismissed or stabled?
-Player who TeleportTo will not carry the corpse of the dead pet with him
* Correction: summoners' pets are always saved alive into db
* Minor corrections
-Now CallPet detects if the hunter doesn't have a current pet, spawned or not
* Ported commits from cm
* Various external fixes - part 8
Ported commits from cmangos repositories
- https://github.com/cmangos/mangos-classic/commit/f4b1f9f
- https://github.com/cmangos/mangos-classic/commit/dc8b867
Simplify debug log output in Unit.cpp
* Fix some rogue issues
-Distract ability was not set the target orientation properly
-Improved Sap restored wrong rank of Stealth
Also revert part of previous commit, due to strange side effects.
Many thanks @mpfans for his support in fixing these issues.
Rogue vanish, hunter feign death, probably invis potion are handled.
Spell is interrupted w/o cooldown set (even if channeled) and mana loss.
https://www.getmangos.eu/issue.php?issueid=736
- Bloodthirst and Mortal Strike have same SpellFamilyFlags
- supress displaying "Spell::EffectSchoolDMG: Spell #id not handled in BTAura"
- this fix applies to ZERO only!
Moved condition related to prevention of casting on self.
Will check the other cores to see if this needs to be applied to them
too.
It does need to be applied to One.
Mostly backported from TC.
Changed table format (mapID in lower 16 bit, areaID in higer 16 bit of data field).
Added CREATURE_SPAWN and GAMEOBJECT_SPAWN disable types.
This will check for the combination of SPELL_ATTR_EX_CHANNELED_1 and SPELL_ATTR_EX3_UNK28 (possible SPELL_ATTR_EX3_ALWAYS_CAST_OK) and ignore UNIT_STAT_CAN_NOT_REACT
Thanks to @vovk
Closescriptdev2/scriptdev2#145
(based on 7ced9cf483)
Signed-off-by: Cala <calaftp@free.fr>
(based on fbf73342c7)
Signed-off-by: Cala <calaftp@free.fr>
- What are the sources for combat movement and when to stop it.
- Also, introduced a check for LoS in Spell::update to cancel the spells earlier
when no LoS.
Known issue: wrong combat logging order. Though the timestamp for spelleffect and instant extra attack is the same, the spelleffect appears later in the log.
Was tested on the Windfury weapon only. Main idea was taken from the TC.
There are only four spells with this combination, all involved in a quest:
* Spell 11637, used by item 9364, for quest 2962.
* Spell 17048, used by item 12848, for quest 5127.
* Spell 22906, used by item 18488, for quest 7509.
* Spell 13982, used by item 11231, for quest 4024. [TBC and Classic only]
