GetBaseWeaponSkillValue and GetBaseDefenseSkillValue -> return GetBaseSkillValue, but this return with added SKILL_PERM_BONUS
Due to this the skilldif formula in Player::UpdateCombatSkills is miscalculating maximum value
I have changed GetBaseWeaponSkillValue and GetBaseDefenseSkillValue to utilize GetPureSkillValue correcting the calculation
Spell 28352 (Breath of Sargeras) is cast on all enemy targets in range
and now properly triggers the Breath of Sargeras (spell 28342)
individual debuff
The trigger value for spells 23209 and 23253 in the Classic DBC files
were wrong: set to 100% chance of triggering spell while tooltip shows
that they should be of 55% and 35% respectively.
Spells were removed in TBC and WotLK DBC files.
Base duration of breath should be 60 seconds in Vanilla and TBC, not 3
minutes as it was changed to in patch 3.0.2 for Wrath (and how it
currently is on cmangos classic)
http://wowwiki.wikia.com/wiki/Breath?oldid=335923http://wowwiki.wikia.com/wiki/Breath
It even states in the uncached, current version of the wiki, my last
link, which patch it was changed in, and what the duration was prior to
that; 60 seconds.
TODO: The forsaken racial trait should be changed to reflect this,
meaning that undead should have 3 minutes base, regardless of what they
had before, as my first link clearly states.
The trigger value for spells 16630 and 16631 in the Classic DBC files
were wrong: set to 100% chance of triggering spell while tooltip shows
that they should be of 67% and 34% respectively.
Values were corrected in the TBC and WotLK DBC files.
* Fix high populated servers latency
- Ported commit from TC repositories
- Fixes server update diffs spikes, generating high latency when many players are online
- Redefined UpdateMask class and removed redundant code from Object.cpp
* Removed extra line of code.
* fix hunter spell Mend pet out Range
fix hunter spell Mend pet out Range deduction MP problem
* fix hunter spell Mend pet out Range
fix hunter spell Mend pet out Range deduction MP problem
* Update SharedDefines.h
* Hunter fixes
-RevivePet will now properly revive the pet
-CallPet will detect if the pet is dead; TODO: what if the pet is dismissed or stabled?
-Player who TeleportTo will not carry the corpse of the dead pet with him
* Correction: summoners' pets are always saved alive into db
* Minor corrections
-Now CallPet detects if the hunter doesn't have a current pet, spawned or not
* Fix "You are in combat" bug.
Ideas taken from TC
* Correct previous commit.
* Improved previous commits
- Creatures in dungeons will not remove distant players from their threat list
- Creatures in non dungeon maps will properly remove the distant players from their threat lists and also players auras from them
* Fix previous commit.
-The creatures will remain tapped by the initial attacker.
-Fix the loot bug
* Fix Charge bug.
-Corrected WorldObject::GetContactPoint to proper compute the final destination point.
-Corrected WorldObject::UpdateAllowedPositionZ to proper adjust the Z value
-Limit the path length computed for EffectCharge. In the event the path cannot be computed, a linear path is applied.
* Fix "You are in combat" bug.
Ideas taken from TC
* Correct previous commit.
* Improved previous commits
- Creatures in dungeons will not remove distant players from their threat list
- Creatures in non dungeon maps will properly remove the distant players from their threat lists and also players auras from them
* Fix previous commit.
-The creatures will remain tapped by the initial attacker.
-Fix the loot bug
* Fix "You are in combat" bug.
Ideas taken from TC
* Correct previous commit.
* Improved previous commits
- Creatures in dungeons will not remove distant players from their threat list
- Creatures in non dungeon maps will properly remove the distant players from their threat lists and also players auras from them