From 35ac315b7005f600691c8e337c16ae9c8b2caf95 Mon Sep 17 00:00:00 2001 From: grahamboree Date: Wed, 24 Dec 2014 15:22:23 -0500 Subject: [PATCH 1/5] Fixed potential memory leak when loading font file. --- RecastDemo/Source/imguiRenderGL.cpp | 1 + 1 file changed, 1 insertion(+) diff --git a/RecastDemo/Source/imguiRenderGL.cpp b/RecastDemo/Source/imguiRenderGL.cpp index 2c4e375..891b300 100644 --- a/RecastDemo/Source/imguiRenderGL.cpp +++ b/RecastDemo/Source/imguiRenderGL.cpp @@ -261,6 +261,7 @@ bool imguiRenderGLInit(const char* fontpath) fclose(fp); if (readLen != size) { + free(ttfBuffer); return false; } From 42afde6273a20bac82773bb5053211018805243c Mon Sep 17 00:00:00 2001 From: grahamboree Date: Wed, 24 Dec 2014 15:29:47 -0500 Subject: [PATCH 2/5] Fixed potential memory leak when loading test case files. --- RecastDemo/Source/TestCase.cpp | 1 + 1 file changed, 1 insertion(+) diff --git a/RecastDemo/Source/TestCase.cpp b/RecastDemo/Source/TestCase.cpp index be72d24..a8e3e4d 100644 --- a/RecastDemo/Source/TestCase.cpp +++ b/RecastDemo/Source/TestCase.cpp @@ -110,6 +110,7 @@ bool TestCase::load(const char* filePath) fclose(fp); if (readLen != 1) { + delete[] buf; return false; } From 91fbf05ec354ab82304d739bb18e0130f9432c8a Mon Sep 17 00:00:00 2001 From: grahamboree Date: Wed, 24 Dec 2014 15:32:50 -0500 Subject: [PATCH 3/5] Uninitialized pointer in TempObstacleCreationTool --- RecastDemo/Source/Sample_TempObstacles.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/RecastDemo/Source/Sample_TempObstacles.cpp b/RecastDemo/Source/Sample_TempObstacles.cpp index b9f8ad3..967f50a 100644 --- a/RecastDemo/Source/Sample_TempObstacles.cpp +++ b/RecastDemo/Source/Sample_TempObstacles.cpp @@ -768,7 +768,7 @@ class TempObstacleCreateTool : public SampleTool public: - TempObstacleCreateTool() + TempObstacleCreateTool() : m_sample(0) { } From ce4c63787b60f38cd71c86712a13290c33919d7f Mon Sep 17 00:00:00 2001 From: grahamboree Date: Wed, 24 Dec 2014 15:34:01 -0500 Subject: [PATCH 4/5] Fixed a potential memory leak when reading a mesh file. --- RecastDemo/Source/MeshLoaderObj.cpp | 1 + 1 file changed, 1 insertion(+) diff --git a/RecastDemo/Source/MeshLoaderObj.cpp b/RecastDemo/Source/MeshLoaderObj.cpp index 2ba8fd8..9c50047 100644 --- a/RecastDemo/Source/MeshLoaderObj.cpp +++ b/RecastDemo/Source/MeshLoaderObj.cpp @@ -155,6 +155,7 @@ bool rcMeshLoaderObj::load(const char* filename) if (readLen != 1) { + delete[] buf; return false; } From 0482a3104c27801c469c7346bcb29d115818d895 Mon Sep 17 00:00:00 2001 From: grahamboree Date: Wed, 24 Dec 2014 15:35:36 -0500 Subject: [PATCH 5/5] Fixed potential memory leak deserializing an InputGeom. --- RecastDemo/Source/InputGeom.cpp | 1 + 1 file changed, 1 insertion(+) diff --git a/RecastDemo/Source/InputGeom.cpp b/RecastDemo/Source/InputGeom.cpp index f1e0186..b532511 100644 --- a/RecastDemo/Source/InputGeom.cpp +++ b/RecastDemo/Source/InputGeom.cpp @@ -178,6 +178,7 @@ bool InputGeom::load(rcContext* ctx, const char* filePath) fclose(fp); if (readLen != 1) { + delete[] buf; return false; }