server_common/recastnavigation_v1.6.0
5
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix a memory leak in dtBuildTileCacheLayer (#212)

Browse Source
This commit is contained in:
Jakob Botsch Nielsen 2016-06-15 10:10:54 +02:00 committed by GitHub
parent 2a0c31b8ef
commit b86c1e12b3
1 changed files with 8 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
DetourTileCache/Source/DetourTileCacheBuilder.cpp
View File

@ -2025,7 +2025,11 @@ dtStatus dtBuildTileCacheLayer(dtTileCacheCompressor* comp,
const int bufferSize = gridSize*3; const int bufferSize = gridSize*3;
unsigned char* buffer = (unsigned char*)dtAlloc(bufferSize, DT_ALLOC_TEMP); unsigned char* buffer = (unsigned char*)dtAlloc(bufferSize, DT_ALLOC_TEMP);
if (!buffer) if (!buffer)
{
dtFree(data);
return DT_FAILURE | DT_OUT_OF_MEMORY; return DT_FAILURE | DT_OUT_OF_MEMORY;
}
memcpy(buffer, heights, gridSize); memcpy(buffer, heights, gridSize);
memcpy(buffer+gridSize, areas, gridSize); memcpy(buffer+gridSize, areas, gridSize);
memcpy(buffer+gridSize*2, cons, gridSize); memcpy(buffer+gridSize*2, cons, gridSize);
@ -2036,7 +2040,11 @@ dtStatus dtBuildTileCacheLayer(dtTileCacheCompressor* comp,
int compressedSize = 0; int compressedSize = 0;
dtStatus status = comp->compress(buffer, bufferSize, compressed, maxCompressedSize, &compressedSize); dtStatus status = comp->compress(buffer, bufferSize, compressed, maxCompressedSize, &compressedSize);
if (dtStatusFailed(status)) if (dtStatusFailed(status))
{
dtFree(buffer);
dtFree(data);
return status; return status;
}
*outData = data; *outData = data;
*outDataSize = headerSize + compressedSize; *outDataSize = headerSize + compressedSize;